[PATCH] os/bluestore/BlueFS: use uint64_t for `len`
authorKefu Chai <kchai@redhat.com>
Fri, 28 Jun 2019 03:35:54 +0000 (11:35 +0800)
committerThomas Goirand <zigo@debian.org>
Wed, 21 Apr 2021 08:02:07 +0000 (09:02 +0100)
commite12a82f711c212c5625a3c1c6cd25f7145853f0a
tree19f1467c20bd91169a638ffbaae58ba15185a534
parent1333dc3590e719fe60cade456689c52418eef52c
[PATCH] os/bluestore/BlueFS: use uint64_t for `len`

change the type of parameter `len` of `BlueFS::_read_random()` from
`size_t` to `uint64_t`.

i think the type of `size_t` comes from
`rocksdb::RandomAccessFile::Read(uint64_t offset, size_t n,
rocksdb::Slice* result, char* scratch)`. and when we implement this
method, we continued using `n`'s type. but, we are using it with
`std::min()`, for instance, where the template parameter type deduction
fails if the lhs and rhs parameters' types are different. so probaly the
better solution is to use `uint64_t` directly to avoid the the cast and
specializing the template.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Gbp-Pq: Name bluefs-use-uint64_t-for-len.patch
src/os/bluestore/BlueFS.cc
src/os/bluestore/BlueFS.h